Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc6 modal improvement #1194

Closed
repetier opened this issue Sep 7, 2016 · 2 comments
Closed

rc6 modal improvement #1194

repetier opened this issue Sep 7, 2016 · 2 comments

Comments

@repetier
Copy link

repetier commented Sep 7, 2016

Bug, feature request, or proposal:

proposal

What is the expected behavior?

easy modal popups

What is the current behavior?

requires module for each popup

Your solution for popups is way to complicated. Had the same issue and this post (not from me) helped me making it much simpler. Essentially use ComponentFactoryResolver and put all potetial popups in your module defintion under
entryComponents:[
PopupComp
]
and you can throw away the one module per popup.

https://blog.thecodecampus.de/angular-2-dynamically-render-components/

@fxck
Copy link
Contributor

fxck commented Sep 7, 2016

#1180

@jelbourn jelbourn closed this as completed Sep 7, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants