Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu divider margins out of spec #14912

Closed
thw0rted opened this issue Jan 22, 2019 · 4 comments
Closed

Menu divider margins out of spec #14912

thw0rted opened this issue Jan 22, 2019 · 4 comments
Assignees
Labels
area: material/divider area: material/menu Fixed in MDC material spec Issue related to the Material Design spec https://material.io/design/ P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@thw0rted
Copy link

What is the expected behavior?

The menu spec shows that a divider in a menu is supposed to have an 8px top/bottom margin.

What is the current behavior?

In the current implementation, the margin is zero.

What are the steps to reproduce?

StackBlitz

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

All? I guess?

Is there anything else we should know?

Trackback to #2017, where the feature was introduced.

@mmalerba mmalerba added the needs triage This issue needs to be triaged by the team label May 20, 2020
@devversion
Copy link
Member

Ideally we'd fix this for our MDC-based menu (#16247). It seems like it would be good to figure out how that menu implementation plays together with the standalone @angular/material/divider.

MDC fixed this, and their demo's show this correctly.. Though our MDC-based menu currently still uses the non-mdc divider.

@devversion devversion added area: material/divider area: material/menu Fixed in MDC material spec Issue related to the Material Design spec https://material.io/design/ P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed needs triage This issue needs to be triaged by the team labels May 29, 2020
@devversion devversion mentioned this issue May 29, 2020
14 tasks
@jelbourn
Copy link
Member

Going to close this as a duplicate of #19248 since I already commented on that one; I don't think this is automatically fixed by MDC because the way we use mat-divider.

@devversion
Copy link
Member

devversion commented May 29, 2020

@jelbourn Sounds good. I didn't realize we had another issue for this. FWIW: I added Fixed in MDC as MDC has this fixed in their menu-surface implementation, but just not we in our MDC-based version. The label might be slightly ambiguous.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/divider area: material/menu Fixed in MDC material spec Issue related to the Material Design spec https://material.io/design/ P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

5 participants