-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MdIconRegistry._setSvgAttributes takes unnecessary config arg #1539
Comments
I believe the config was added as an argument because there will be options later, but I don't remember what those options are off the top of my head. @dozingcat do you remember? |
|
As per the discussion angular#1539, there are a few places in the icon registry where the config is being passed without actually being used. This change removes those instances and does some minor cleanup. Fixes angular#1539.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
MdIconRegistry._setSvgAttributes
makes use of all the args passed to it.What is the current behavior?
MdIconRegistry._setSvgAttributes
takes aconfig
arg but doesn't use it.What are the steps to reproduce?
Simply read the code
What is the use-case or motivation for changing an existing behavior?
Cleanup
Which versions of Angular, Material, OS, browsers are affected?
@angular/material 2.0.0-alpha.9-3
Is there anything else we should know?
No
The text was updated successfully, but these errors were encountered: