Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Add output for onCentered #3032

Closed
vladimir-ivanov opened this issue Feb 10, 2017 · 2 comments · Fixed by #6811
Closed

[Tabs] Add output for onCentered #3032

vladimir-ivanov opened this issue Feb 10, 2017 · 2 comments · Fixed by #6811
Assignees
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@vladimir-ivanov
Copy link

Bug, feature request, or proposal:

Feature request

What is the expected behavior?

I would like to have have a hook on top level (@output property) on md-tab-group to know when the sliding in animation as defined in MdTabBody completed.
Ideally proxying @output() onCentered from MdTabBody on MdTabGroup component to re emit.

What is the current behavior?

We don't have an option to resize third party components once the slide in has completed ->
this._portalHost.attach happens initially in ngAfterViewChecked for MdTabBody, but at that point the portalHost element does not have width and height defined, which the child component we are attaching can not size itself correctly.

What is the use-case or motivation for changing an existing behavior?

So nested components inside tabs which are not active get correct width and height properties/ or allow them to be resized on animation complete -> e.g. onCentered.emit() for MdTabBody

Which versions of Angular, Material, OS, browsers are affected?

@angular: "2.4.1"
@angular/material: "2.0.0-beta.1"

@kara kara added the feature This issue represents a new feature or feature request rather than a bug or bug fix label Feb 10, 2017
@amcdnl
Copy link
Contributor

amcdnl commented Oct 3, 2017

PR in progress for this - #6811

@andrewseguin andrewseguin changed the title md-tab-group - add @Output() onCentered on MdTabGroup component [Tabs] Add output for onCentered Oct 19, 2017
@andrewseguin andrewseguin added has pr P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed mat-tabs labels Oct 19, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants