Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus indicators on md-fab is really subtle #420

Closed
hansl opened this issue May 10, 2016 · 4 comments · Fixed by #467
Closed

Focus indicators on md-fab is really subtle #420

hansl opened this issue May 10, 2016 · 4 comments · Fixed by #467
Assignees
Labels
Accessibility This issue is related to accessibility (a11y)

Comments

@hansl
Copy link
Contributor

hansl commented May 10, 2016

Hard to see the difference unless you really focus on it.

@hansl hansl added the Accessibility This issue is related to accessibility (a11y) label May 10, 2016
@jelbourn jelbourn changed the title Focus indicators on fab-button is really subtle Focus indicators on md-fab is really subtle May 11, 2016
@jelbourn
Copy link
Member

The FAB spec describes the focus state for FABs as having an "ink wash", but it's not really clear what that means. I'll follow up with MD UX to see if there is some more guidance.

@traviskaufman
Copy link
Contributor

Looks like the only place we use the term "ink wash" is in that description.

Essentially, a FAB focus behaves the same as a focus on a raised button (in fact in many aspects a FAB can be thought of as a raised button that's circular and has a higher elevation; the biggest differences are semantic. It gets its own section due to the importance and uniqueness of the component within a material app). That phrase should either be clarified or reworded within spec.

@jelbourn
Copy link
Member

jelbourn commented May 19, 2016

I've opened #467 to make our buttons match what the spec says, but I still find the focus indication to be quite subtle. I'm going to close this issue with my PR, but I've also filed a bug with the Material Design UX team and will revisit based on their answer.

@jelbourn jelbourn self-assigned this May 19, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants