Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog documentation example is not so good #4388

Closed
HarelM opened this issue May 4, 2017 · 4 comments
Closed

Dialog documentation example is not so good #4388

HarelM opened this issue May 4, 2017 · 4 comments

Comments

@HarelM
Copy link

HarelM commented May 4, 2017

Breaking of #4367:

Bug

Dialog example doesn't show the dialog code
the dialog is too simple - dialog should probably include inputs and outputs.

@LilSebastian5000
Copy link

Just an FYI - If I'm understanding your first issue correctly, you can view the dialog code by clicking the "Edit In Plunker" icon at the top right of the example.

@HarelM
Copy link
Author

HarelM commented May 5, 2017

Didn't know that, Thanks!
But I'm sure other like me would look for it in the main page and not in the plunker example, so I believe the documentation page should include it as well...

@jelbourn
Copy link
Member

jelbourn commented Jun 7, 2017

Tracking via angular/material.angular.io#165

@jelbourn jelbourn closed this as completed Jun 7, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants