Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(Datepicker): datepicker doesn't close if you click on previous selected date #5349

Closed
julianobrasil opened this issue Jun 24, 2017 · 8 comments
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@julianobrasil
Copy link
Contributor

julianobrasil commented Jun 24, 2017

Bug, feature request, or proposal:

Bug/Request (I think I've seen a similar issue around, but I couldn't find it)

What is the expected behavior?

The datepicker should close if you click on a previous selected date

What is the current behavior?

The datepicker doesn't close if you click on a previous selected date

What are the steps to reproduce?

1 - Open the calendar, select a date
2 - Reopen the calendar and try to select the same date

Plunker: http://plnkr.co/edit/shFewF?p=preview

What is the use-case or motivation for changing an existing behavior?

It's not unusual that a user opens the calendar, takes a quick look at it and realizes that the date he wants to select is already selected. In this situation, the calendar panel should close if he clicks again on the already selected date.

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

@angular/cli: 1.1.3
node: 6.10.3
os: win32 x64
@angular/animations: 4.2.4
@angular/common: 4.2.4
@angular/compiler: 4.2.4
@angular/compiler-cli: 4.2.4
@angular/core: 4.2.4
@angular/flex-layout: 2.0.0-beta.8
@angular/forms: 4.2.4
@angular/http: 4.2.4
@angular/material: 2.0.0-beta.7
@angular/platform-browser: 4.2.4
@angular/platform-browser-dynamic: 4.2.4
@angular/platform-server: 4.2.4
@angular/router: 4.2.4
@angular/cli: 1.1.3
@angular/language-service: 4.2.4

Google Chrome

Is there anything else we should know?

@julianobrasil julianobrasil changed the title bug(Datepicker): datepicker don't close if you click on previous selected date bug(Datepicker): datepicker doesn't close if you click on previous selected date Jun 24, 2017
@mmalerba mmalerba added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Jun 30, 2017
@hwesol13
Copy link
Contributor

hwesol13 commented Jul 10, 2017

@mmalerba is there any progress in this issue? I'm just wondering if i could fix that but i don't want to duplicate your work (if you already did any).

@mmalerba
Copy link
Contributor

@hwesol13 I haven't gotten a chance yet, feel free to create a PR and mention me

@hwesol13
Copy link
Contributor

Ok so i'll fix it than :)

@mmalerba
Copy link
Contributor

@hwesol13 are you still planning on creating a PR for this?

@lukaszzdanikowski
Copy link

Hi @mmalerba, @hwesol13 is currently on holidays but he should submit PR next week

@julianobrasil
Copy link
Contributor Author

Any news about this?

@hwesol13 @mmalerba

@julianobrasil
Copy link
Contributor Author

Oh, I found it: #6323

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

No branches or pull requests

4 participants