Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay directive #879

Closed
jmurphzyo opened this issue Jul 18, 2016 · 4 comments · Fixed by #1660
Closed

overlay directive #879

jmurphzyo opened this issue Jul 18, 2016 · 4 comments · Fixed by #1660
Labels
help wanted The team would appreciate a PR from the community to address this issue

Comments

@jmurphzyo
Copy link

jmurphzyo commented Jul 18, 2016

Bug, feature request, or proposal:

bug

What is the expected behavior?

n/a

What is the current behavior?

Possible typo

What are the steps to reproduce?

Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: http://plnkr.co/edit/o077B6uEiiIgkC0S06dd

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, browsers are affected?

Material2 latest

Is there anything else we should know?

n/a

I believe there is a typo here https://github.com/angular/material2/blob/master/src/core/overlay/overlay-directives.ts#L91
originX is set to overlayX position. I don't know if that was intended.

@kara kara added the help wanted The team would appreciate a PR from the community to address this issue label Jul 23, 2016
@sendilkumarn
Copy link
Contributor

Think that should be originX

@karan1276
Copy link

Hey, i am a student and a little new to material 2. I want to become a regular contributor because angular is so awesome :)

I would like to work on this issue, if someone is already working on that please let me know .

Any advice on how to go about it is also appreciated :)

Thank you

@karan1276
Copy link

@jmurphzyo I can't find anything wrong with the plunker demo. Looks like overlay-lay directive has a typo but did something go wrong because of it?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
help wanted The team would appreciate a PR from the community to address this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants