refactor(input): run autofill monitor outside the NgZone #10367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
reviewed
Mar 12, 2018
src/lib/input/autofill.ts
Outdated
| element.addEventListener('animationstart', listener, listenerOptions); | ||
| element.classList.add('mat-input-autofill-monitored'); | ||
| this._ngZone.runOutsideAngular(() => { | ||
| element.addEventListener('animationstart', listener, listenerOptions); |
There was a problem hiding this comment.
Can you put it back in the zone when we emit on the observable? That way users don't have to do it themselves
crisbeto
force-pushed
the
autofill-monitor-ngzone
branch
from
7834ef9 to
5d22f60
Compare
mmalerba
approved these changes
Mar 12, 2018
mmalerba
added
pr: lgtm
action: merge
Switches the autofill monitor to run outside the `NgZone`, because it toggles classes on the element directly and it has the potential of being fired very often if the user has other animations on the element. Also adds a description to an output that is part of the public API.
crisbeto
force-pushed
the
autofill-monitor-ngzone
branch
from
5d22f60 to
277b454
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches the autofill monitor to run outside the
NgZone, because it toggles classes on the element directly and it has the potential of being fired very often if the user has other animations on the element. Also adds a description to an output that is part of the public API.