Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(icon): remove 6.0.0 deletion targets #10389

Merged
merged 1 commit into from
Mar 14, 2018
Merged

refactor(icon): remove 6.0.0 deletion targets #10389

merged 1 commit into from
Mar 14, 2018

Conversation

crisbeto
Copy link
Member

Removes the material/icon deletion targets for 6.0.0.

BREAKING CHANGES:

  • The _document parameter in the MatIconRegistry constructor is now required.

@crisbeto
refactor(icon): remove 6.0.0 deletion targets
0894eda 
Removes the `material/icon` deletion targets for 6.0.0.

BREAKING CHANGES:
* The `_document` parameter in the `MatIconRegistry` constructor is now required.
@crisbeto crisbeto requested a review from jelbourn as a code owner March 13, 2018 03:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 13, 2018
jelbourn
jelbourn approved these changes Mar 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 13, 2018
@mmalerba mmalerba merged commit e8af5ae into angular:master Mar 14, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Mar 19, 2018
@crisbeto @josephperrott
refactor(icon): remove 6.0.0 deletion targets (angular#10389)
a8b574b 
Removes the `material/icon` deletion targets for 6.0.0.

BREAKING CHANGES:
* The `_document` parameter in the `MatIconRegistry` constructor is now required.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @mmalerba