docs(tree): add cdk tree examples to material-examples #10426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
tinayuangao
added
target: major
jelbourn
reviewed
Mar 14, 2018
| .example-tree ul, | ||
| .example-tree li { | ||
| -webkit-margin-before: 0; | ||
| -webkit-margin-after: 0; |
There was a problem hiding this comment.
Why are these prefixed styles necessary?
| @@ -0,0 +1,9 @@ | |||
| <cdk-tree [dataSource]="dataSource" [treeControl]="treeControl"> | |||
| <cdk-tree-node *cdkTreeNodeDef="let node" cdkTreeNodePadding class="demo-tree-node"> | |||
| <a [attr.aria-label]="'toggle ' + node.filename" cdkTreeNodeToggle class="demo-tree-toggle"> | |||
There was a problem hiding this comment.
Anchor elements should only be used for navigation (should always have an href). For actions, you should use a styled <button>.
| * Build the file structure tree. The `value` is the Json object, or a sub-tree of a Json object. | ||
| * The return value is the list of `FileNode`. | ||
| */ | ||
| buildFileTree(value: any, level: number) { |
There was a problem hiding this comment.
Can the return type on this be more specific?
|
@jelbourn Addressed comments and also updated the material examples. |
tinayuangao
force-pushed
the
cdk-tree-examples-docs
branch
2 times, most recently
from
4559d0a to
e3039b0
Compare
tinayuangao
force-pushed
the
cdk-tree-examples-docs
branch
from
e3039b0 to
d2359ad
Compare
jelbourn
added
pr: lgtm
action: merge
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Mar 19, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.