Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(text-field): make constructor parameters required #10431

Merged
merged 1 commit into from
Mar 19, 2018
Merged

refactor(text-field): make constructor parameters required #10431

merged 1 commit into from
Mar 19, 2018

Conversation

crisbeto
Copy link
Member

Makes the _ngZone parameter in CdkTextareaAutosize a required one. This was intended as a deletion target, but we hadn't set up deletion targets when it was added.

BREAKING CHANGES:

  • The _ngZone parameter in the CdkTextareaAutosize constructor is now required.

@crisbeto
refactor(text-field): make constructor parameters required
2eb42c0 
Makes the `_ngZone` parameter in `CdkTextareaAutosize` a required one. This was intended as a deletion target, but we hadn't set up deletion targets when it was added.

BREAKING CHANGES:
* The `_ngZone` parameter in the `CdkTextareaAutosize` constructor is now required.
@crisbeto crisbeto requested a review from mmalerba as a code owner March 15, 2018 09:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Mar 15, 2018
josephperrott
josephperrott approved these changes Mar 15, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed pr: needs review labels Mar 15, 2018
@andrewseguin andrewseguin merged commit 5e5aae3 into angular:master Mar 19, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott josephperrott approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@crisbeto @josephperrott @googlebot @mmalerba @andrewseguin