docs(form-field): update documentation regarding label and placeholder #11037
Conversation
mmalerba
added
pr: needs review
target: patch
googlebot
added
the
cla: yes
src/lib/form-field/form-field.html
Outdated
| @@ -22,13 +22,15 @@ | |||
| *ngIf="_hasFloatingLabel()" | |||
| [ngSwitch]="_hasLabel()"> | |||
|
|
|||
| <!-- @deletion-target 7.0.0 remove in favor of mat-label element an placeholder attr. --> | |||
There was a problem hiding this comment.
If we're deprecating it in 6, then I believe the deletion target has to be v8
src/lib/form-field/form-field.md
Outdated
| `mat-label` element. | ||
|
|
||
| In the legacy version of the `<mat-form-field>` (one that has no `appearance` attribute or has | ||
| `appearance="legacy"`) if a label is not specified the `placeholder` attribute on the form control |
There was a problem hiding this comment.
Needs a comma before the placeholder.
src/lib/select/select.md
Outdated
| [form field placeholder documentation](https://material.angular.io/components/form-field/overview#floating-placeholder). | ||
| The placeholder is text shown when the `<mat-form-field>` label is floating but the `<mat-select>` | ||
| is empty. It is used to give the user an additional hint about the value they should select. The | ||
| placeholder can be specified by setting the `placeholder` on the `<mat-select>` element. In some |
There was a problem hiding this comment.
"the placeholder" -> "the placeholder attribute"
mmalerba
force-pushed
the
placeholder-doc
branch
from
e057016 to
3f319cf
Compare
|
comments addressed |
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
fixes #10830