fix(button): theme font color being overwritten #9771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
changed the title
devversion
force-pushed
the
fix/no-color-plain-buttons
branch
from
5f96312 to
1725324
Compare
|
@jelbourn I differentiated between |
devversion
force-pushed
the
fix/no-color-plain-buttons
branch
from
03e0f7b to
f35a666
Compare
mmalerba
added
pr: lgtm
action: merge
mmalerba
added
presubmit failures
|
caretaker note: there's a number of broken screendiffs where the button color is wrong (black on dark themes, etc) |
This was referenced Feb 9, 2018
devversion
force-pushed
the
fix/no-color-plain-buttons
branch
from
f35a666 to
f3b930b
Compare
devversion
changed the title
* Currently buttons with a background color (e.g. flat buttons, raised buttons, fabs) receive a font color by the theme. This font color is accidentally being overwritten by the normal button CSS that sets the `color` for every button to `inherit`. This can cause the text to be invisible in a dark theme. From now on, those buttons will no longer inherit the font color accidentally. * Normal buttons, stroked buttons and icon buttons will still inherit the font color, because it's wrong to assume that those buttons are always placed inside of containers with the default background color. Otherwise those buttons would be invisible in some containers with a different background color (e.g. in a themed toolbar). * Removes the SSR check for `hasHostAttributes`. This method is essential for the color of the buttons, and needs to run inside of SSR. (now possible with Domino anyway) * Cleans up the button theme while being at it. Fixes angular#4614. Fixes angular#9231. Fixes angular#9634
devversion
force-pushed
the
fix/no-color-plain-buttons
branch
from
f3b930b to
32b234e
Compare
devversion
removed
pr: lgtm
presubmit failures
|
Just a ping for review. As mentioned in the standup. This is pretty high priority IMO. |
jelbourn
added
pr: lgtm
action: merge
devversion
added
P2
|
changes were approved a month ago, looks like CI failed because of rate limit exceeded or missing tokens, any idea when this will be merged? |
jelbourn
added
target: major
|
Has this been solved in 5.2.5? I'm still having this issue in 5.2.5.. |
|
This is tagged as a |
|
If your font color is black in a dark theme, that's your problem, not the button's. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #9536
Currently buttons with a background color (e.g. flat buttons, raised buttons, fabs) receive a font color by the theme. This font color is accidentally being overwritten by the normal button CSS that sets the
colorfor every button toinherit. This can cause the text to be invisible in a dark theme. From now on, those buttons will no longer inherit the font color accidentally.Normal buttons, stroked buttons and icon buttons will still inherit the font color, because it's wrong to assume that those buttons are always placed inside of containers with the default background color. Otherwise those buttons would be invisible in some containers with a different background color (e.g. in a themed toolbar).
Removes the SSR check for
hasHostAttributes. This method is essential for the color of the buttons, and needs to run inside of SSR. (now possible with Domino anyway)Cleans up the button theme while being at it.
Fixes #4614. Fixes #9231. Fixes #9634