Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

fxLayoutAlign conflicts with fxFlex breakpoint evaluation #1010

Closed
silvioboehme opened this issue Jan 29, 2019 · 6 comments · Fixed by #1038
Closed

fxLayoutAlign conflicts with fxFlex breakpoint evaluation #1010

silvioboehme opened this issue Jan 29, 2019 · 6 comments · Fixed by #1038
Assignees
Labels
bug has pr A PR has been created to address this issue P3 Important issue that needs to be resolved
Milestone

Comments

@silvioboehme
Copy link

Bug Report

image

<div fxLayout="row" fxFlex.gt-sm="25%" fxFlex.lt-md="100%" fxLayoutAlign="center end" class="sec1">

This div (red) should be 25% for breakpoints greater 960px and 100% for all lower resolutions.
This works fine if you refresh the page at MD breakpoint (first screenshot), but if you increase the size to LG the div (red) gets 100% of the size. This depends on the fxLayoutAlign directive. If you remove this, then everything works fine. But with fxLayoutAlign the breakpoint for fxFlex are not evaluated, if you resize the browser.

What is the expected behavior?

This works fine in 7.0.0-beta19

What is the current behavior?

This breaks in all version greater than 7.0.0-beta20

What are the steps to reproduce?

https://stackblitz.com/edit/angular-flex-layout-seed-dtspn2

Just resize the output window

@taivu
Copy link

taivu commented Jan 29, 2019

happening on beta 22 as well.

@silvioboehme
Copy link
Author

Yes, all version greater beta 19 are affected

@CaerusKaru
Copy link
Member

I don't think we'll be able to get to this issue this week, but we will try and get it fixed by the next release. Thanks for tracking this down!

@CaerusKaru CaerusKaru added bug in-progress P0 Critical issue that needs to be resolved immediately and removed needs: investigation labels Feb 6, 2019
@CaerusKaru CaerusKaru self-assigned this Feb 6, 2019
@CaerusKaru CaerusKaru added this to the 7.0.0-beta.24 milestone Feb 6, 2019
@CaerusKaru
Copy link
Member

So the title of this issue is not exactly accurate. What happens in fxFlex generation is that it adds a max-width/max-height/etc, which ultimately gets overwritten by/overwrites fxLayoutAlign. This question of "who wins" will require further thought.

@CaerusKaru CaerusKaru added P3 Important issue that needs to be resolved and removed P0 Critical issue that needs to be resolved immediately labels Feb 6, 2019
@CaerusKaru CaerusKaru changed the title fxLayoutAlign breaks fxFlex breakpoint evaluation fxLayoutAlign conflicts with fxFlex breakpoint evaluation Feb 6, 2019
@tonysamperi
Copy link

tonysamperi commented Feb 7, 2019

yep. same here. I solved downgrading to 7.0.0-beta.19

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug has pr A PR has been created to address this issue P3 Important issue that needs to be resolved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants