fix(show-hide): use initial value as fallback instead of parent #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SSR creates media screen styles, it sets the default `display` CSS property to `parent.display`. However, if the parent has its `display` property unset, it results in an empty display that breaks the correct functionality as the next closest match is made. This is fixed by setting `display` to `initial` as default instead of an empty value. Credit to @vmasek Fixes #1163
CaerusKaru
force-pushed
the
adam/fix-issue-1163
branch
from
e4bb7ef
to
4012b17
Compare
CaerusKaru
changed the title
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SSR creates media screen styles, it sets the default
displayCSS property to
parent.display. However, if the parent has itsdisplayproperty unset, it results in an empty display that breaksthe correct functionality as the next closest match is made.
This is fixed by setting
displaytoinitialas default insteadof an empty value.
Credit to @vmasek
Fixes #1163
Closes #1168