Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): only emit changed events from MediaObserver #1377

Merged
merged 1 commit into from
Dec 23, 2021

Conversation

CaerusKaru
Copy link
Member

It is unfortunately the case in a real-world browser environment
that overlapping breakpoints trigger separate events in our change
monitoring schema. This is (nearly) unavoidable, but what we can
do is ensure that we only emit distinct events for our event
aggregator, MediaObserver. We now only emit when we get an entirely
distinct set of media changes from the previous state.

Fixes #1041

It is unfortunately the case in a real-world browser environment
that overlapping breakpoints trigger separate events in our change
monitoring schema. This is (nearly) unavoidable, but what we can
do is ensure that we only emit distinct events for our event
aggregator, MediaObserver. We now only emit when we get an entirely
distinct set of media changes from the previous state.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 23, 2022
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MediaObserver.asObservable() emits two events on each change
1 participant