feat(fxFlex): compute immediate parent flex-direction #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBurleson
force-pushed
the
thomas/fix-flex-computed-directions
branch
6 times, most recently
from
8d9c596
to
2ea5dfd
Compare
ThomasBurleson
changed the title
ThomasBurleson
force-pushed
the
thomas/fix-flex-computed-directions
branch
3 times, most recently
from
8f319a8
to
fc823bb
Compare
Support use of **fxFlex** directive on HTML element without a **fxLayout** parent directive. Previous versions of **fxFlex** required a `flex-direction` to be specific on the immediate parent. Current version improved: * use defined flex-direction or getComputed. * auto-inject **fxLayout** styles to parent if parent `flex-direction` not already provided. * fix ngOnDestory() with fxLayoutWrap
ThomasBurleson
force-pushed
the
thomas/fix-flex-computed-directions
branch
from
fc823bb
to
3bfeddd
Compare
|
@mmalerba - ready for presubmit. Thx. |
karlhaas
pushed a commit
to karlhaas/flex-layout
that referenced
this pull request
May 3, 2017
Support use of **fxFlex** directive on HTML element without a **fxLayout** parent directive. Previous versions of **fxFlex** required a `flex-direction` to be specific on the immediate parent. Current version improved: * use defined flex-direction or getComputed. * auto-inject **fxLayout** styles to parent if parent `flex-direction` not already provided. * fix ngOnDestory() with fxLayoutWrap
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support use of fxFlex directive on HTML element without a fxLayout parent
directive. fxFlex requires a
flex-directionto be specific on the immediate parent:flex-directionnot already provided.