Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

ClassDirective throws renderer error with Angular 5.0.0-beta.5 #398

Closed
0x-r4bbit opened this issue Aug 29, 2017 · 8 comments · Fixed by #391
Closed

ClassDirective throws renderer error with Angular 5.0.0-beta.5 #398

0x-r4bbit opened this issue Aug 29, 2017 · 8 comments · Fixed by #391
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease

Comments

@0x-r4bbit
Copy link

0x-r4bbit commented Aug 29, 2017

This is because @angular/flex-layout doesn't support Angular's Renderer2 yet, which is the only supported version in Angular 5.0.0-beta.5. Prior to that release, Renderer could be used as well and flex-layout takes advantage of that service in NgClass extensions.

screen shot 2017-08-29 at 8 19 11 am

I've opened the original issue over at @angular/angular right HERE

Also, it seems this will likely be fixed with #391 which is pending right now.

@ThomasBurleson ThomasBurleson added the has pr A PR has been created to address this issue label Aug 29, 2017
@ThomasBurleson ThomasBurleson added this to the v2.0.0-beta.10 milestone Aug 29, 2017
@ThomasBurleson ThomasBurleson added the P1 Urgent issue that should be resolved before the next re-lease label Aug 29, 2017
@ThomasBurleson
Copy link
Contributor

@angular/flex-layout has a ClassDirective to support responsive APIs for class and ngClass.

This directive no longer extends the ngClass fro @angular/core. Instead it internally composes an instances of this class (if needed) and delegates actions to that instance.

With @mhevery's help, the Flex-Layout now uses a Renderer2.

@kelsmj
Copy link

kelsmj commented Aug 31, 2017

Any idea when this fix will be committed?

@ThomasBurleson
Copy link
Contributor

The PR(s) are in the queue and should be merged into master today. We hope to publish Beta.10 soon.

@kelsmj
Copy link

kelsmj commented Aug 31, 2017

Great, thanks....this one bit me

@spock123
Copy link

spock123 commented Sep 1, 2017

Dang cost me 2 days to figure out where it came from.. the old fashioned remove one component/module at a time until I was down to Angular/Flex :)

Looking forward to the update, guys :) thanks

The renaming and breaking change of renderer -> renderer2 occurred back in Angular 4.0 rc.1:

@spock123
Copy link

spock123 commented Sep 5, 2017

Hi guys, any news about this?

It doesn't appear to have been merged into master yet... nobody is able to upgrade to Angular 5 beta 5 or beta 6...

Thanks for your great work, really hoping for this to be merged soon.

@ThomasBurleson
Copy link
Contributor

@spock123 - hopefully this will be merged today.

@ThomasBurleson ThomasBurleson changed the title bug: @angular/flex-layout throws with Angular 5.0.0-beta.5 ClassDirective renderer error throws with Angular 5.0.0-beta.5 Sep 6, 2017
@ThomasBurleson ThomasBurleson changed the title ClassDirective renderer error throws with Angular 5.0.0-beta.5 ClassDirective throws renderer error with Angular 5.0.0-beta.5 Sep 6, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
has pr A PR has been created to address this issue P1 Urgent issue that should be resolved before the next re-lease
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants