Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(fxFlex): apply correct flex-basis stylings #629

Merged
merged 1 commit into from
Mar 9, 2018
Merged

fix(fxFlex): apply correct flex-basis stylings #629

merged 1 commit into from
Mar 9, 2018

Conversation

CaerusKaru
Copy link
Member

  • Fix for when flex-basis is unitless and 0
  • Fix for when no width/height is applied and flex-basis should be
    set
  • Fix for IE flex-basis with calc values
  • Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534

@CaerusKaru CaerusKaru added this to the v6.0.0-beta.14 milestone Feb 25, 2018
@CaerusKaru CaerusKaru force-pushed the adam/fix-basis branch 3 times, most recently from 4ae757f to 1a3029f Compare February 25, 2018 07:46
@CaerusKaru CaerusKaru force-pushed the adam/fix-basis branch 4 times, most recently from a0ac344 to 7ab5d34 Compare March 9, 2018 22:01
@CaerusKaru
fix(fxFlex): apply correct flex-basis stylings
6f8c7ab 
* Fix for when flex-basis is unitless and 0
* Fix for when no width/height is applied and flex-basis should be
  set
* Fix for IE flex-basis with calc values
* Fix for SSR properties set to 0

Fixes #277
Fixes #280
Fixes #323
Fixes #528
Fixes #534
@CaerusKaru CaerusKaru merged commit 1e96cea into master Mar 9, 2018
@CaerusKaru CaerusKaru deleted the adam/fix-basis branch March 9, 2018 22:52
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@ThomasBurleson ThomasBurleson

Labels
cla: yes flexbox pr: needs review
Projects
None yet
Milestone
v5.0.0-beta.14
3 participants
@CaerusKaru @ThomasBurleson @googlebot