Skip to content
This repository has been archived by the owner on Jan 6, 2025. It is now read-only.

feat(core): move MatchMedia to internal scope #998

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Conversation

CaerusKaru
Copy link
Member

@CaerusKaru CaerusKaru commented Jan 15, 2019

BREAKING CHANGE:

  • MatchMedia is no longer exported as a public utility. Please use MediaObserver instead.
  • ServerMatchMedia is no longer exported at all

@ThomasBurleson ThomasBurleson added pr: lgtm This PR has been approved by the reviewer and removed pr: needs review labels Jan 15, 2019
@ThomasBurleson ThomasBurleson merged commit 53a6ebb into master Jan 15, 2019
@CaerusKaru CaerusKaru deleted the adam/mmi branch January 15, 2019 20:55
@willyboy
Copy link

willyboy commented Jun 17, 2019

@CaerusKaru We were using mockMatchMedia to activate different breakpoints in tests. What's the preferred approach now? I could open a docs PR with a bit of direction.

@MaT1g3R
Copy link

MaT1g3R commented Jun 24, 2019

Hello, is there any updates on this? We are using MockMatchMedia too and we would like to know what is the preferred approach now as well, thanks.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes pr: lgtm This PR has been approved by the reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants