Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialog example should include code from dialog-result-example-dialog.html #149

Closed
jrood opened this issue Apr 26, 2017 · 2 comments
Closed

Comments

@jrood
Copy link

jrood commented Apr 26, 2017

The overview for the Dialog talks about using elements such as <md-dialog-content> and <md-dialog-actions>. However, no examples of actual code using these elements is visible, because that code would be in the dialog-result-example-dialog.html file (referenced in the .ts files in both the overview and the example), but the actual content of that html file is not visible anywhere.

@jrood
Copy link
Author

jrood commented Apr 26, 2017

Also, it's not clear whether DialogResultExampleDialog needs to be an entry component or how it might need to be referenced in the app.module.ts. (I'm willing to make a second issue for this if anyone thinks that is necessary.)

@jelbourn
Copy link
Member

jelbourn commented Jun 7, 2017

Tracking via #165

@jelbourn jelbourn closed this as completed Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants