fix(slide-toggle): match theme with specs #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Oct 26, 2016
| } | ||
| } | ||
|
|
||
| .md-slide-toggle-thumb { | ||
| background-color: md-color($background, background); | ||
| background-color: md-color($md-grey, $thumb-off-hue); |
There was a problem hiding this comment.
$thumb-off-hue is only used in one place, so I would do this here instead:
$thumb-background: if($is-dark, md-color(...), md-color(...));| $primary: map-get($theme, primary); | ||
| $accent: map-get($theme, accent); | ||
| $warn: map-get($theme, warn); | ||
| $background: map-get($theme, background); | ||
| $foreground: map-get($theme, foreground); | ||
|
|
||
| $thumb-on-hue: if($is-dark, 200, 500); |
| $primary: map-get($theme, primary); | ||
| $accent: map-get($theme, accent); | ||
| $warn: map-get($theme, warn); | ||
| $background: map-get($theme, background); | ||
| $foreground: map-get($theme, foreground); | ||
|
|
||
| $thumb-on-hue: if($is-dark, 200, 500); |
There was a problem hiding this comment.
Can you add a comment here with a link to the spec and explaining the use of different hues based on light vs. dark theme?
* Currently the theme stylesheet for the slide-toggle was not following the specs. * This commit ensures that the stylesheet follows the specs with all details (https://material.google.com/components/selection-controls.html#selection-controls-switch) Fixes angular#1568.
devversion
force-pushed
the
fix/slide-toggle-theme-spec
branch
from
c0ef774
to
689ebbf
Compare
|
LGTM |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jelbourn
$thumb-on-hue- we can't place mixins inside of mixins (so I'd rather make a follow up and discuss possible approaches)Fixes #1568.