Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(overlay): ensure container covers entire screen #1634

Merged
merged 1 commit into from
Oct 27, 2016
Merged

fix(overlay): ensure container covers entire screen #1634

merged 1 commit into from
Oct 27, 2016

Conversation

jelbourn
Copy link
Member

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 27, 2016
@jelbourn jelbourn force-pushed the overlay-container-size branch from ef513ab to 04f2e2f Compare October 27, 2016 17:44
@jelbourn
Copy link
Member Author

Had to update stylelint config to allow vw (though vh was already in there...)

@mmalerba
Copy link
Contributor

LGTM

@jelbourn jelbourn merged commit af39236 into angular:master Oct 27, 2016
@jelbourn jelbourn deleted the overlay-container-size branch September 13, 2017 04:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@mmalerba mmalerba

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jelbourn @mmalerba @googlebot