feat(overlay): add fullscreen-enabled overlay class

[quanterion]

New PR implementing fullscreen mode support https://developer.mozilla.org/en-US/docs/Web/API/Element/requestFullScreen
cc: @jelbourn

[jelbourn]

@quanterion can you also add corresponding unit tests?

[jelbourn]

This class should go in its own file

[jelbourn]

Needs a class description that explains what this class is for specifically.

[jelbourn]

Need a comment here like

// When the page is put into fullscreen mode, a specific element is specified. 
// Only that element and its children are visible when in fullscreen mode. 

[quanterion]

@jelbourn, comments addresed, also renamed container to FullscreenOverlayContainer as it sounds less verbose, can revert back to old name if it is not appropriate.

I tried do add unit-tests like this:

it('should move container into a fullscreen element', () => {
    let c = overlayContainer.getContainerElement();    
    expect(c.parentElement).toBe(document.body);
    let fullscreenPane = document.createElement('div');
    document.body.appendChild(fullscreenPane);
    activateFullscreen(fullscreenPane);
    expect(c.parentElement).toBe(fullscreenPane);
    exitFullscreen();
    expect(c.parentElement).toBe(document.body);
    fullscreenPane.remove();
  });

But they are failing because Chrome says: Failed to execute 'requestFullScreen' on 'Element': API can only be initiated by a user gesture.

[jelbourn]

@quanterion sounds like we'd need to use an e2e test for this behavior, then, since webdriver acts as user interaction. Can you add an e2e test for this?

[quanterion]

@jelbourn added e2e tests and rebased on top of the master

[quanterion]

@jelbourn rebased on top of the latest sdk changes and tests starts failing and I can't understand why, the errors seems to be unrelated to my changes

[quanterion]

@jelbourn tests successfully passed after latest rebase

[quanterion]

@jelbourn any chance it can be reviewed?

[jelbourn]

@quanterion working on getting through the backlog of PRs in the wake of beta and holidays now

[jelbourn]

@quanterion mostly looks good, just a few last comments

[jelbourn]

We typically omit the public access modifier since it's the default

[jelbourn]

I'd prefer to omit this function from here, since it falls outside of the responsibility of the OverlayContainer

[quanterion]

@jelbourn comments addressed and rebased

[jelbourn]

LGTM, thanks!

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}