Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-spinner: color binding not working #2393

Closed
xgqfrms-GitHub opened this issue Dec 24, 2016 · 1 comment · Fixed by #2396
Closed

md-spinner: color binding not working #2393

xgqfrms-GitHub opened this issue Dec 24, 2016 · 1 comment · Fixed by #2396
Assignees
@devversion

Comments

@xgqfrms-GitHub
Copy link

it seems that there was no different among of the below codes!

what's wrong with this?

<md-spinner mode="indeterminate"></md-spinner>
<md-spinner mode="determinate"></md-spinner>
<md-spinner color="primary"></md-spinner>
<md-spinner color="accent"></md-spinner>
<md-spinner color="warn"></md-spinner>

https://plnkr.co/edit/U5iKFrTyqaAQttE6i0Xh?p=preview
color-spin-error
@devversion devversion self-assigned this Dec 24, 2016
@devversion devversion changed the title bugs! md-spinner: color binding not working Dec 24, 2016
devversion added a commit to devversion/material2 that referenced this issue Dec 24, 2016
@devversion
fix(prgoress-spinner): fix color input on md-spinner
5c763b1 
* Makes color application dynamic by moving it to a getter / setter. (similar to all other components & makes it easier to share the code in the future)
* Now the `md-spinner` can also have a `color` binding.
* Fixes the missing documentation for the `color` and `value` inputs
* Removes the unused `changeDetectorRef` from the constructor DI

Fixes angular#2393
@devversion devversion mentioned this issue Dec 24, 2016
Merged
devversion added a commit to devversion/material2 that referenced this issue Dec 24, 2016
@devversion
fix(prgoress-spinner): fix color input on md-spinner
953618f 
* Makes color application dynamic by moving it to a getter / setter. (similar to all other components & makes it easier to share the code in the future)
* Now the `md-spinner` can also have a `color` binding.
* Fixes the missing documentation for the `color` and `value` inputs
* Removes the unused `changeDetectorRef` from the constructor DI

Fixes angular#2393
devversion added a commit to devversion/material2 that referenced this issue Dec 24, 2016
@devversion
fix(progress-spinner): fix color input on md-spinner
bdf4aef 
* Makes color application dynamic by moving it to a getter / setter. (similar to all other components & makes it easier to share the code in the future)
* Now the `md-spinner` can also have a `color` binding.
* Fixes the missing documentation for the `color` and `value` inputs
* Removes the unused `changeDetectorRef` from the constructor DI

Fixes angular#2393
@kara kara closed this as completed in #2396 Jan 4, 2017
kara pushed a commit that referenced this issue Jan 4, 2017
@devversion @kara
fix(progress-spinner): fix color input on md-spinner (#2396)
6cb6576 
Fixes #2393
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(progress-spinner): fix color input on md-spinner devversion/material2
2 participants
@devversion @xgqfrms-GitHub