Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autocomplete): placeholder should float while panel is open #2730

Merged
merged 1 commit into from
Feb 3, 2017
Merged

fix(autocomplete): placeholder should float while panel is open #2730

merged 1 commit into from
Feb 3, 2017

Conversation

kara
Copy link
Contributor

@kara kara commented Jan 20, 2017 •
edited
Loading

Ready for review

r: @jelbourn

@kara kara requested review from jelbourn and andrewseguin January 20, 2017 02:46
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 20, 2017
@kara kara force-pushed the autocomplete-placeholder branch from 1939a7e to ebe2fed Compare January 25, 2017 01:58
andrewseguin
andrewseguin approved these changes Jan 30, 2017
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 30, 2017
@kara kara removed the action: merge The PR is ready for merge by the caretaker label Jan 30, 2017
@kara kara force-pushed the autocomplete-placeholder branch from ebe2fed to cfc7c55 Compare February 3, 2017 02:30
@kara kara added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Feb 3, 2017
@kara kara merged commit 1eebca9 into angular:autocomplete Feb 3, 2017
kara added a commit that referenced this pull request Feb 3, 2017
@kara
fix(autocomplete): placeholder should float while panel is open (#2730)
eec4dc6
@gedclack
Copy link

gedclack commented Apr 1, 2017

Hi, I am new in github and also new to angular,
I met this situation where Input's placeholder still floats even after I set floatPlaceholder="never" in the <md-input-container>, is this intentional according to this commit ?

@dahaupt
Copy link

dahaupt commented Apr 1, 2017

@gedclack If you have a question you can ask it in https://gitter.im/angular/material2 and in case you think it's an issue in the library, you can open an issue.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kara @gedclack @dahaupt @andrewseguin @jelbourn @googlebot