fix(autocomplete): double-clicking input shouldnt close the panel #2835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kara
force-pushed
the
autocomplete-blur
branch
from
46122d6
to
e0338d5
Compare
andrewseguin
approved these changes
Feb 1, 2017
| @@ -85,22 +87,18 @@ describe('MdAutocomplete', () => { | |||
| .toContain('California', `Expected panel to display when opened programmatically.`); | |||
| }); | |||
|
|
|||
| it('should close the panel when a click occurs outside it', async(() => { | |||
| it('should close the panel when blurred', async(() => { | |||
There was a problem hiding this comment.
Can you include a test checking that the panel is open after changing focus to an md-option?
There was a problem hiding this comment.
You mean when you make the md-option active by the keyboard, right? Focus never changes to md-option unless you click on it, in which case the panel should close.
There was a problem hiding this comment.
Added another test in the keyboard events section for that
kara
force-pushed
the
autocomplete-blur
branch
from
e0338d5
to
770cce6
Compare
kara
force-pushed
the
autocomplete-blur
branch
from
770cce6
to
9f6393a
Compare
kara
added a commit
to kara/material2
that referenced
this pull request
Feb 3, 2017
kara
added a commit
that referenced
this pull request
Feb 3, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review.
r: @jelbourn @andrewseguin