Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toolbar): add toolbar role to host element #2914

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

devversion
Copy link
Member

  • Add the toolbar role attribute to the host element to have proper accessibility support.

Fixes #2909

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 3, 2017
* Add the toolbar `role` attribute to the host element to have proper accessibility support.

Fixes angular#2909
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Feb 5, 2017
@tinayuangao tinayuangao merged commit 67032ca into angular:master Feb 6, 2017
@devversion devversion deleted the fix/toolbar-role-attr branch November 11, 2017 10:19
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: md-toolbar should have role of toolbar
5 participants