feat(slide-toggle): use ripple service #3068
Conversation
* Removes the temporary ripple mixin and uses the new ripple service. * Updates the ripple colors to match the specification images (no explicit opacity values are specified) * Triggers ripple on label mousedown (similar as in the Android Nougat implementation) Closes angular#2900.
googlebot
added
the
cla: yes
| border-radius: 50%; | ||
| z-index: 1; | ||
| pointer-events: none; | ||
| } |
There was a problem hiding this comment.
You should check if your editor has an option to add \n on save :p I think most editors have some type of option for this.
There was a problem hiding this comment.
@mmalerba Why is it useful to have a newline at the end of each file? Or is this just convention? Always wondered about that 😄
There was a problem hiding this comment.
Haha. That's a good idea. I've had so many lint issues with that - Thanks! 😄
There was a problem hiding this comment.
@dahaupt good question, I never thought about why that's the convention we use, but apparently that's just how lines are defined: http://stackoverflow.com/questions/729692/why-should-text-files-end-with-a-newline
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@mmalerba I intentionally created separate variables for the
checkedripple colors because I want to have all spec-aligned stuff at the top of the@mixinso we can easily make changes.Closes #2900.