feat(FocusOriginMonitor): support monitoring subtree focus as well as element #3113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
reviewed
Feb 15, 2017
src/lib/core/style/focus-classes.ts
Outdated
| // Create monitored element info. | ||
| let info: MonitoredElementInfo = { | ||
| unlisten: null, | ||
| includesChildren: includeChildren, |
src/lib/core/style/focus-classes.ts
Outdated
| // focused element. | ||
| window.addEventListener('focus', () => { | ||
| this._windowFocused = true; | ||
| setTimeout(() => this._windowFocused = false, 0); |
There was a problem hiding this comment.
Just an optional nit. How about extracting this into its own function?
constructor(ngZone: NgZone) {
ngZone.runOutsideAngular(() => this._registerDocumentEvents());
}This way we would get rid of unnecessary indentation and also have it pretty clean.
devversion
approved these changes
Feb 16, 2017
src/lib/core/style/focus-classes.ts
Outdated
|
|
||
| // If we are not counting child-element-focus as focused, make sure that the event target is the | ||
| // monitored element itself. | ||
| if (!this._elementInfo.get(element).checkChildren && element != event.target) { |
There was a problem hiding this comment.
I think that we should use === as often as possible. Also in the setClasses method.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also includes some cleanup:
registerElementForFocusClassestomonitorunmonitormethod and call on directive destroyedcdkFocusClasseswithcdkMonitorElementFocusandcdkMonitorSubtreeFocus