Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-tab-nav-bar: ink doesn't change with resizing tabs #3845

Closed
willshowell opened this issue Mar 30, 2017 · 2 comments · Fixed by #3877
Closed

md-tab-nav-bar: ink doesn't change with resizing tabs #3845

willshowell opened this issue Mar 30, 2017 · 2 comments · Fixed by #3877

Comments

@willshowell
Copy link
Contributor

Bug, feature request, or proposal:

Bug

What is the current behavior?

When the window hits the $mat-xsmall breakpoint, min widths for .mat-tab-label and .mat-tab-link change from 160px to 72px. The ink bar does not reflect that.

What are the steps to reproduce?

http://plnkr.co/edit/6NlXoXhzaDHsHtTo9JWn?p=preview

Which versions of Angular, Material, OS, browsers are affected?

Master

Other Info

Related to #3044 but does not require tabs to be stretched.
@willshowell willshowell mentioned this issue Mar 30, 2017
Closed
@crisbeto crisbeto added the has pr label Apr 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 2, 2017
@crisbeto
fix(tabs): re-align the ink bar when the viewport size changes
e8daabf 
* Recalculates the ink bar position, as well as the pagination, if the viewport size changes.
* Adds a missing test on the `tab-nav-bar` regarding repositioning on direction changes.

Fixes angular#3845.
Fixes angular#3044.
Fixes angular#2518.
Fixes angular#1231.
@crisbeto crisbeto mentioned this issue Apr 2, 2017
Merged
@jelbourn
Copy link
Member

jelbourn commented Apr 9, 2017

Dupe of #3044

@jelbourn jelbourn closed this as completed Apr 9, 2017
kara pushed a commit that referenced this issue Apr 21, 2017
@crisbeto @kara
fix(tabs): re-align the ink bar when the viewport size changes (#3877)
7942948 
Fixes #3845.
Fixes #3044.
Fixes #2518.
Fixes #1231.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tabs): re-align the ink bar when the viewport size changes crisbeto/material2
3 participants
@jelbourn @crisbeto @willshowell