Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(card, list): Update MdCard and MdListItem color property to use theme's text color. #3952

Merged
merged 1 commit into from
Apr 21, 2017
Merged

fix(card, list): Update MdCard and MdListItem color property to use theme's text color. #3952

merged 1 commit into from
Apr 21, 2017

Conversation

kyle-burke
Copy link
Contributor

Fixes #3936.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 7, 2017
@kyle-burke kyle-burke changed the title Update MdCard and MdListItem color property to use theme's text color. fix(card, list): Update MdCard and MdListItem color property to use theme's text color. Apr 7, 2017
@kyle-burke kyle-burke mentioned this pull request Apr 7, 2017
Closed
@kyle-burke
Copy link
Contributor Author

The screenshot tests were sharp enough to notice the slight change in opacity. Could someone tell me how to provide that test suite with an updated screenshot? I don't see anything in the Contributing file for doing this (might be worth a separate PR to describe this process)

jelbourn
jelbourn approved these changes Apr 9, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Apr 9, 2017
@kara kara merged commit 5e7af26 into angular:master Apr 21, 2017
@willshowell willshowell mentioned this pull request May 5, 2017
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MdCard and MdListItem use base color rather than text color
4 participants
@kyle-burke @jelbourn @kara @googlebot