fix(input-container): New attribute hideRequiredMarker #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer This attribute will enable the user to hide the required marker (star) fron an mdInput even when it's required Fixes angular#3681
googlebot
added
the
cla: yes
mmalerba
reviewed
Apr 24, 2017
| @@ -371,6 +371,16 @@ describe('MdInputContainer', function () { | |||
| expect(el.nativeElement.textContent).toMatch(/hello\s+\*/g); | |||
| }); | |||
|
|
|||
| it('hide placeholder required star when set to hide the required marker', () => { | |||
| let fixture = TestBed.createComponent(MdInputContainerPlaceholderRequiredTestComponent); | |||
| fixture.componentInstance.hideRequiredMarker = true; | |||
There was a problem hiding this comment.
check that it has the * initially
devversion
reviewed
Apr 24, 2017
src/demo-app/input/input-demo.html
Outdated
| @@ -245,6 +245,14 @@ | |||
| </md-input-container> | |||
| </p> | |||
| <p> | |||
| <md-checkbox [(ngModel)]="hideRequiredMarker"> Check to hide the required marker:</md-checkbox> | |||
There was a problem hiding this comment.
Can we remove that leading space for the content?
… the '*' before applying the 'hideRequiredMarker' attribute on test. Removing extra leading space on hideRequiredMarker demo.
|
@mmalerba @devversion done |
mmalerba
approved these changes
Apr 24, 2017
mmalerba
added
pr: lgtm
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attribute will enable the user to hide the required marker (star) from an mdInput even when it's required
Fixes #3681