Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): no longer export internal type #4390

Merged
merged 1 commit into from
May 11, 2017

Conversation

devversion
Copy link
Member

  • Currently the ElementBoundingsPosition type is only used internally by the ConnectedPositionStrategy and the export is unnecessary.
  • Doesn't make any sense to export this type to the public while it's just internally used.

@devversion devversion requested a review from jelbourn May 4, 2017 18:27
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 4, 2017
* Currently the `ElementBoundingsPosition` type is only used internally by the `ConnectedPositionStrategy` and the export is unnecessary.
* Doesn't make any sense to export this type to the public while it's just internally used.
@devversion devversion force-pushed the fix/overlay-export-internal branch from e3d00ee to 54ed33f Compare May 6, 2017 14:35
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 10, 2017
@kara kara merged commit 136f7ff into angular:master May 11, 2017
@devversion devversion deleted the fix/overlay-export-internal branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants