Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): fix padding for list items #4486

Merged
merged 1 commit into from
May 11, 2017
Merged

Conversation

kara
Copy link
Contributor

@kara kara commented May 11, 2017

Now that ripples are always the first children of the list content div, the selector overriding the padding needs to be updated.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 11, 2017
@kara kara requested a review from jelbourn May 11, 2017 19:43
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 11, 2017
@devversion
Copy link
Member

Ugh. I wonder if there is a better approach of doing this. Looks very error-prone for future changes too.

@kara
Copy link
Contributor Author

kara commented May 11, 2017

@devversion Feel free to submit a PR after this if you can think of a better way. Currently Google tests are broken and need to be fixed.

@kara kara merged commit d1d2e18 into angular:master May 11, 2017
@devversion
Copy link
Member

Yeah thanks for fixing it that quick! Just wondered if we can make it more flexible at some point.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants