fix(checkbox): margin for empty checkboxes incorrectly added #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
in progress
|
It makes me generally unhappy that even something as simple as checkbox has to have a |
devversion
force-pushed
the
fix/checkbox-label-watch
branch
from
b1c66cc
to
6dfd6cc
Compare
devversion
added
pr: needs review
and removed
in progress
|
@jelbourn Reworked it a bit more. Yeah I'm not too happy with the solution either. |
With angular#2121 the margin will be removed for checkboxes that don't have any label set. A problem is that the Checkbox uses the OnPush change detection strategy and therefore the checkbox is not able to detect any delayed / async label change. This means that checkboxes that set their label from an async binding will not have any margin until the users clicks on the checkbox. Using the `cdkObserveContent` seems to be an elegant approach when using the OnPush strategy. The `:empty` CSS selector would be more elegant but it's very sensitive about whitespaces and therefore it doesn't work properly. Fixes angular#4720
devversion
force-pushed
the
fix/checkbox-label-watch
branch
from
6dfd6cc
to
0bc14f0
Compare
jelbourn
approved these changes
Jun 6, 2017
jelbourn
added
pr: lgtm
action: merge
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 6, 2017
* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730) Fixes angular#6868
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 7, 2017
* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730) Fixes angular#6868
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 7, 2017
* Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730) Fixes angular#6868
mmalerba
pushed a commit
that referenced
this pull request
Sep 12, 2017
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Sep 15, 2017
…ngular#6881) * Removes the side-margin of the actual indicator of the slide-toggle if the user label is empty (similar as in angular#4730) Fixes angular#6868
|
is there any workaround now for ^5.1.0 ? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #2121 the margin will be removed for checkboxes that don't have any label set.
A problem is that the Checkbox uses the OnPush change detection strategy and therefore the checkbox is not able to detect any delayed / async label change.
This means that checkboxes that set their label from an async binding will not have any margin until the users clicks on the checkbox.
Using the
cdkObserveContentseems to be an elegant approach when using the OnPush strategy.The
:emptyCSS selector would be more elegant but it's very sensitive about whitespaces and therefore it doesn't work properly.Fixes #4720