Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay attachments observable is triggered before the attachment is complete #4871

Closed
alex-okrushko opened this issue May 29, 2017 · 1 comment · Fixed by #4880
Closed

Overlay attachments observable is triggered before the attachment is complete #4871

alex-okrushko opened this issue May 29, 2017 · 1 comment · Fixed by #4880
Assignees
@crisbeto

Comments

@alex-okrushko
Copy link
Contributor

Bug, feature request, or proposal:

bug

What is the expected behavior?

Observable should be triggered when the attachment is complete

What is the current behavior?

It's triggered before that

What are the steps to reproduce?

see plunker

Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U

http://embed.plnkr.co/aNgzEWACkFlAzOC0ZyfJ/

What is the use-case or motivation for changing an existing behavior?

Is there anything else we should know?

push .next() to attachments at the end of the attach() method should fix the issue.
@crisbeto crisbeto self-assigned this May 30, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue May 30, 2017
@crisbeto
fix(overlay): emit attach and detach at appropriate times
5a1c098 
* Emits the `attachments` when everything has been attached.
* Emits the `detachments` when everything has been detached.
* Completes the `attachments` observable before the `detachments`.

Fixes angular#4871.
@crisbeto crisbeto mentioned this issue May 30, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue May 31, 2017
@crisbeto
fix(overlay): emit attach and detach at appropriate times
cfad200 
* Emits the `attachments` when everything has been attached.
* Emits the `detachments` when everything has been detached.
* Completes the `attachments` observable before the `detachments`.

Fixes angular#4871.
crisbeto added a commit to crisbeto/material2 that referenced this issue May 31, 2017
@crisbeto
fix(overlay): emit attach and detach at appropriate times
d81b57c 
* Emits the `attachments` when everything has been attached.
* Emits the `detachments` when everything has been detached.
* Completes the `attachments` observable before the `detachments`.

Fixes angular#4871.
crisbeto added a commit to crisbeto/material2 that referenced this issue Jun 6, 2017
@crisbeto
fix(overlay): emit attach and detach at appropriate times
efea69e 
* Emits the `attachments` when everything has been attached.
* Emits the `detachments` when everything has been detached.
* Completes the `attachments` observable before the `detachments`.

Fixes angular#4871.
andrewseguin pushed a commit that referenced this issue Jun 6, 2017
@crisbeto @andrewseguin
fix(overlay): emit attach and detach at appropriate times (#4880)
e98372e 
* Emits the `attachments` when everything has been attached.
* Emits the `detachments` when everything has been detached.
* Completes the `attachments` observable before the `detachments`.

Fixes #4871.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(overlay): emit attach and detach at appropriate times crisbeto/material2
2 participants
@alex-okrushko @crisbeto