Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove align input from MdInputContainer #5140

Closed
jelbourn opened this issue Jun 14, 2017 · 1 comment · Fixed by #5141
Closed

Remove align input from MdInputContainer #5140

jelbourn opened this issue Jun 14, 2017 · 1 comment · Fixed by #5141
Assignees
@devversion
Labels
help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@jelbourn
Copy link
Member

All this does is set text-align which could easily be done with user-space CSS.
@jelbourn jelbourn added help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion labels Jun 14, 2017
@devversion devversion self-assigned this Jun 15, 2017
devversion added a commit to devversion/material2 that referenced this issue Jun 15, 2017
@devversion
update(input): remove align input binding
b2dccaf 
* The `align` input property for the `md-input-container` is not doing anything special and can be easily replaced with normal CSS from the user.

BREAKING CHANGE: The `align` input from the `<md-input-container>` component has been removed. Developers instead should use plain CSS to archive the same (using `text-align: end` for example)

Fixes angular#5140
@devversion devversion mentioned this issue Jun 15, 2017
Merged
kara pushed a commit that referenced this issue Jun 16, 2017
@devversion @kara
chore(input): remove align input binding (#5141)
0aaeb69 
BREAKING CHANGE: The `align` input from the `<md-input-container>` component has been removed. Developers instead should use plain CSS to achieve the same effect (using `text-align: end` for example).

Fixes #5140.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@devversion devversion

Labels
help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update(input): remove align input binding devversion/material2
2 participants
@jelbourn @devversion