Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input): invalid font declaration #5154

Merged
merged 1 commit into from
Jul 26, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 15, 2017

Fixes the font declaration on the md-input-container being ignored, because it was invalid.

Note: I updated the font size to the correct value from the spec, however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select.

Fixes #5262.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 15, 2017
Fixes the `font` declaration on the `md-input-container` being ignored, because it was invalid.

Note: I updated the font size to the correct value from [the spec](https://material.io/guidelines/components/text-fields.html#text-fields-states), however I'm not using it, in order to avoid any breaking changes. Also note that since the line height wasn't being used before, the baseline is now slightly off when next to a select.

Fixes angular#5262.
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 21, 2017
@jelbourn jelbourn added presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note and removed presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels Jun 22, 2017
@jelbourn
Copy link
Member

Caretaker note: Screenshot diffs need approval

@sougiovn
Copy link

When will it be released for installing?

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid font CSS for mat-input-container class
6 participants