Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(card): unable to bind to align attribute #5495

Merged
merged 1 commit into from
Jul 14, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jul 4, 2017

Fixes not being able to bind to the align attribute on the md-card-actions.

Note: If we're okay with a breaking change, this may be simpler to do with a CSS class.

Fixes #5490.

Fixes not being able to bind to the `align` attribute on the `md-card-actions`.

Fixes angular#5490.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 4, 2017
@jelbourn
Copy link
Member

jelbourn commented Jul 5, 2017

I'm in general interested in changing behaviors like this to use just css classes, but it's something we'd have to do for the whole library. Any thoughts?

@crisbeto
Copy link
Member Author

crisbeto commented Jul 5, 2017

I prefer the CSS classes as well since these bindings just add unnecessary bloat. I can do it in the few other places that we have something similar, but it'll be a breaking change.

@jelbourn
Copy link
Member

jelbourn commented Jul 5, 2017

Might be good to first compile a list of places where we could do this and see how major the change would be

@crisbeto
Copy link
Member Author

crisbeto commented Jul 8, 2017

@jelbourn here's a list where changes would be necessary:

  • align on md-card.
  • align on md-dialog-actions.
  • dense on md-list.
  • fullscreen on md-sidenav.
  • md-stretch-tabs on md-tabs.

There's also the mode input on md-progress-bar and md-progress-spinner, but I think that we should keep it there since the components need to react on mode changes. Should I go ahead with the list from above?

@jelbourn
Copy link
Member

jelbourn commented Jul 8, 2017

Let me see how widely they're used inside Google first

@jelbourn
Copy link
Member

About:

  • 6 uses on md-dialog-actions
  • 32 for md-card-actions
  • 20 for md-list
  • I would want to skip sidenav anyway since we're working on changing that separately
  • Tabs is hard to tell because the same property exists in material1

It would be pretty time consuming to update these, so updating the binding is how I would go for now. If we run out of more important stuff to do before end-of-beta then we can revisit.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 12, 2017
@jelbourn jelbourn merged commit 243b97d into angular:master Jul 14, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-card-actions align property not known when binding
3 participants