fix for checkbox opacity issues in safari #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| @@ -24,7 +24,7 @@ $md-toggle-size: 20px !default; | |||
| // TODO(jelbourn): all of these need to be revisited | |||
|
|
|||
| // The default animation curves used by material design. | |||
| $md-linear-out-slow-in-timing-function: cubic-bezier(0.0, 0.0, 0.2, 0.1) !default; | |||
There was a problem hiding this comment.
I'd prefer not to change this in this PR and instead do a review directly with the Material Design UX team.
There was a problem hiding this comment.
Can you guide on how?
There was a problem hiding this comment.
I mean to just revert this line here.
There was a problem hiding this comment.
Okay then. Will change this and background thing
This reverts commit db62acf.
|
LGTM |
|
Thanks! |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#557
Variables - changed cubic-beizer for linear-out-slow-in based on this
Calculation of opacity value in safari has some issues when rendering and it corrects itself upon moving focus out of window. i.e., on recalculating.
moved background and opacity from
.md-checkbox-backgroundand set them dynamically upon checkbox transition.