Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete,select): inconsistent disabled option coloring #6640

Merged
merged 1 commit into from
Sep 1, 2017

Conversation

crisbeto
Copy link
Member

  • Fixes a selected and disabled option in the autocomplete not showing as disabled until it is hovered.
  • Fixes the disabled and selected options in md-select using the theme color, instead of the disabled color.
  • Fixes the disabled state of an option not being passed down to its checkbox.

Fixes #6638.

* Fixes a selected and disabled option in the autocomplete not showing as disabled until it is hovered.
* Fixes the disabled and selected options in `md-select` using the theme color, instead of the disabled color.
* Fixes the disabled state of an option not being passed down to its checkbox.

Fixes angular#6638.
@crisbeto crisbeto requested a review from kara as a code owner August 25, 2017 18:17
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 25, 2017
@crisbeto crisbeto changed the title ffix(autocomplete,select): inconsistent disabled option coloring fix(autocomplete,select): inconsistent disabled option coloring Aug 25, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment Aug 31, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Aug 31, 2017
@jelbourn jelbourn merged commit 454781d into angular:master Sep 1, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[autocomplete] conflicting "disabled" and "selected" styles on option hover
4 participants