fix(menu): nested menu error when items are rendered in a repeater #6766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
6765/nested-menu-repeater
branch
from
1722b5a
to
bc679f8
Compare
kara
reviewed
Sep 26, 2017
src/lib/menu/menu-directive.ts
Outdated
| @@ -76,8 +78,11 @@ export class MdMenu implements AfterContentInit, MdMenuPanel, OnDestroy { | |||
| /** Subscription to tab events on the menu panel */ | |||
| private _tabSubscription: Subscription; | |||
|
|
|||
| /** Stream that emits whenever the component is intialized. */ | |||
| private _initialized = new Subject<void>(); | |||
There was a problem hiding this comment.
Instead of creating another Subject to track initialization, how about using NgZone.onStable ?
There was a problem hiding this comment.
I’m not sure whether the timing is the same.
There was a problem hiding this comment.
I stand corrected, it does work.
crisbeto
force-pushed
the
6765/nested-menu-repeater
branch
from
bc679f8
to
96409ac
Compare
|
Addressed the feedback @kara, PTAL. |
kara
added
pr: lgtm
action: merge
|
@crisbeto Thanks for making this fix. Could you please let me know of when we can expect this changes merged? Looking forward to using this nested menus. Thanks, |
Fixes an error that was being thrown when the menu items that trigger a sub-menu are rendered in a repeater. Fixes angular#6765.
crisbeto
force-pushed
the
6765/nested-menu-repeater
branch
from
38de0a7
to
9f8734a
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error that was being thrown when the menu items that trigger a sub-menu are rendered in a repeater.
Fixes #6765.