Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change focus-trap control attributes to camelCase #6799

Closed
jelbourn opened this issue Sep 1, 2017 · 3 comments
Closed

Change focus-trap control attributes to camelCase #6799

jelbourn opened this issue Sep 1, 2017 · 3 comments
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@jelbourn
Copy link
Member

jelbourn commented Sep 1, 2017

cdkFocusTrap currently uses the attributes cdk-focus-initial, cdk-focus-start, and cdk-focus-end. We should change these to camelCase for consistency (even though they aren't directive selectors).
@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Sep 1, 2017
@jelbourn
Copy link
Member Author

jelbourn commented Sep 1, 2017

cc @mmalerba

amcdnl added a commit to amcdnl/material2 that referenced this issue Sep 9, 2017
@amcdnl
fix(focus-trap): update focus trap attrs to camel case angular#6799
da9c1ea
@amcdnl amcdnl mentioned this issue Sep 9, 2017
Merged
@amcdnl amcdnl added the has pr label Sep 11, 2017
@willshowell willshowell mentioned this issue Oct 24, 2017
Closed
mmalerba pushed a commit that referenced this issue Oct 27, 2017
@amcdnl @mmalerba
fix(focus-trap): update focus trap attrs to camel case #6799 (#6960)
c663fad 
* fix(focus-trap): update focus trap attrs to camel case #6799

* chore(nit): update to use lower case names

* chore(nit): fix typo

* chore(demo): update demos

* chore(nit): fix pr feedback
@willshowell
Copy link
Contributor

I think this can be closed.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@amcdnl @jelbourn @willshowell @mmalerba