Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sort): reverse directions and better animation #6802

Merged
merged 4 commits into from
Sep 18, 2017
Merged

fix(sort): reverse directions and better animation #6802

merged 4 commits into from
Sep 18, 2017

Conversation

andrewseguin
Copy link
Contributor

Fixes #6198

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2017
jelbourn
jelbourn reviewed Sep 1, 2017
View reviewed changes
src/lib/sort/sort-header.ts Outdated
@@ -52,8 +52,8 @@ import {getMdSortHeaderNotContainedWithinMdSortError} from './sort-errors';
changeDetection: ChangeDetectionStrategy.OnPush,
animations: [
trigger('indicatorRotate', [
state('asc', style({transform: 'rotate(45deg)'})),
state('desc', style({transform: 'rotate(225deg)'})),
state('asc', style({transform: 'rotate(225deg)', top: '2px'})),
Copy link
Member

@jelbourn jelbourn Sep 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with the 2px? Needs a comment at least

@andrewseguin andrewseguin changed the title fix(sort): directions are reversed fix(sort): reverse directions and better animation Sep 5, 2017
@andrewseguin andrewseguin mentioned this pull request Sep 5, 2017
Closed
jelbourn
jelbourn approved these changes Sep 5, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 5, 2017
@andrewseguin andrewseguin added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Sep 14, 2017
@jelbourn jelbourn merged commit 6fa9e6f into angular:master Sep 18, 2017
@mcalmus
Copy link
Contributor

mcalmus commented Sep 25, 2017

I haven't been able to reproduce it with a simple test case (and can't upload my regular site), but with this patch in place (beta 11), I'm seeing the sort header "stem" and indicator appearing horizontally next to one another rather than vertically.

I was able to fix this by (with the debugger) adding a "flex-direction: column" style to the "mat-sort-header-arrow" class.

Would it be possible to do so in the official release?

@jelbourn
Copy link
Member

@mcalmus Please open an issue for bug reports.

@mcalmus mcalmus mentioned this pull request Sep 25, 2017
Closed
@andrewseguin andrewseguin deleted the sort-indicators-backwards branch November 28, 2017 20:39
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MdTable sort indicators backwards
4 participants
@andrewseguin @mcalmus @jelbourn @googlebot