Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

md-select change event fires twice on keyboard navigation #7227

Closed
atinybeardedman opened this issue Sep 21, 2017 · 1 comment · Fixed by #7232
Closed

md-select change event fires twice on keyboard navigation #7227

atinybeardedman opened this issue Sep 21, 2017 · 1 comment · Fixed by #7232
Assignees
@crisbeto

Comments

@atinybeardedman
Copy link

Bug, feature request, or proposal:

Bug

What is the expected behavior?

change event should fire only once per selection

What is the current behavior?

the change event as well as the ngModelChange event fires twice when using the up and down arrows on the keyboard to select a value.

What are the steps to reproduce?

This occurs only when the item is in focus and the keyboard is used (no panel is shown).

Providing a Plunker (or similar) is the best way to get the team to see your issue.

https://plnkr.co/edit/0tnDAA?p=preview

What is the use-case or motivation for changing an existing behavior?

Which versions of Angular, Material, OS, TypeScript, browsers are affected?

Angular 4.3.5
Material beta.10
Tested in chrome

Is there anything else we should know?
@crisbeto crisbeto self-assigned this Sep 21, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Sep 21, 2017
@crisbeto
fix(select): multiple change events emitted when changing options of …
4fe422b 
…a closed select

Prevents two change events being fired the same change when selecting an option via the arrow keys on a closed select.

Fixes angular#7227.
@crisbeto crisbeto mentioned this issue Sep 21, 2017
Merged
andrewseguin pushed a commit that referenced this issue Sep 29, 2017
@crisbeto @andrewseguin
fix(select): multiple change events emitted when changing options of …
c7ab828 
…a closed select (#7232)

Prevents two change events being fired the same change when selecting an option via the arrow keys on a closed select.

Fixes #7227.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@crisbeto @atinybeardedman