fix(ripple): use element coordinates instead of page coordinates #7446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
approved these changes
Sep 30, 2017
devversion
added
pr: lgtm
action: merge
devversion
reviewed
Sep 30, 2017
| @@ -10,7 +10,6 @@ import {Directionality} from '@angular/cdk/bidi'; | |||
| import {coerceBooleanProperty} from '@angular/cdk/coercion'; | |||
| import {Platform} from '@angular/cdk/platform'; | |||
| import {auditTime, takeUntil} from '@angular/cdk/rxjs'; | |||
| import {ViewportRuler} from '@angular/cdk/scrolling'; | |||
There was a problem hiding this comment.
We should also remove the VIEWPORT_RULER_PROVIDER in the ripple module actually.
crisbeto
force-pushed
the
7436/ripple-refactor
branch
from
b2e1ab5
to
a48670e
Compare
Uses the `clientX` and `clientY` coordinates when creating a ripple, instead of taking `pageX`/`pageY` and subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position. Fixes angular#7436.
crisbeto
force-pushed
the
7436/ripple-refactor
branch
from
a48670e
to
8620ebd
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the
clientXandclientYcoordinates when creating a ripple, instead of takingpageX/pageYand subtracting the scroll position since the result is exactly the same. Using the client coordinates has the advantage of being simpler and not having to read the scroll position.Fixes #7436.