fix(table): throw error when missing row defs #7751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
approved these changes
Oct 12, 2017
src/cdk/table/table.ts
Outdated
| @@ -175,6 +177,10 @@ export class CdkTable<T> implements CollectionViewer { | |||
| } | |||
|
|
|||
| ngAfterContentInit() { | |||
| if (!this._headerDef && this._rowDefs.length == 0) { | |||
jelbourn
added
pr: lgtm
action: merge
andrewseguin
added
the
P4
andrewseguin
force-pushed
the
table-error-on-missing-row
branch
from
4d52e41
to
cd4d34d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When users forgot to include a
<cdk-header-row>and<cdk-row>, the error messaging is vague and not helpful. This provides a check to help them know where to start with debugging