Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slide-toggle): fix runtime exception for incorrect mousedown binding #828

Merged
merged 1 commit into from
Jul 7, 2016

Conversation

devversion
Copy link
Member

  • Commit fad4ef5 made all internal functions prefixed with an underscore.
    The commit did accidentally miss to add the underscore the (mousedown) host binding function, which
    causes a Runtime Exception now.

cc. @jelbourn

…ing.

* Commit fad4ef5 made all internal functions prefixed with an underscore.
  The commit did accidentally miss to add the underscore the `(mousedown)` host binding function, which
  causes a Runtime Exception now.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 7, 2016
@jelbourn
Copy link
Member

jelbourn commented Jul 7, 2016

@devversion thanks!

@jelbourn jelbourn merged commit bbbc87f into angular:master Jul 7, 2016
@devversion devversion deleted the fix/slide-toggle-wrong-prefix branch July 7, 2016 21:49
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants